Skip to content

fix: select the Unix trash backend explicitly - #429

Merged
Byron merged 1 commit into
mainfrom
trash-build
Nov 9, 2026
Merged

Byron merged 1 commit into
mainfrom
trash-build

Conversation

@Byron

@Byron Byron commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Tasks

This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.

  • refackiew

Everything below this line was generated by GPT-6.

Created by Codex on behalf of Byron. Byron will review before this is ready to merge.

Fixes #428.

Source installation resolves trash 5.3.0, which requires a Unix backend feature. dua disables trash's defaults, so Linux compilation fails with a missing platform module. The lockfile's older trash 5.2.5 masked the failure in CI.

Enable freedesktop through a target-specific dependency for the Unix platforms supported by that backend. macOS and Windows retain their native backends, and disabling trash-move still omits trash entirely. Require trash 5.3.0 because earlier releases do not expose the new feature, and refresh the lockfile.

Add a CI check of Cargo's resolved backend features for Linux, FreeBSD, macOS, and Windows. The check failed before the fix; a Linux cross-check also reproduced the three compiler errors reported in the issue.

Validation passed:

  • sh ci/check-trash-features.sh
  • Linux cargo check --locked with defaults, no defaults, and trash-move only
  • make check-pre-push (feature combinations, tests, journey tests, formatting, and Clippy)

A new dua-cli release will be needed to repair source installation of the already-published 3.0.0.

<!-- agent -->
Installing `dua-cli` with an unlocked dependency graph selects trash 5.3.0,
which now requires either freedesktop or portal on supported Unix targets.
dua disables dependency defaults, so the platform module was missing.
The existing lockfile pinned 5.2.5 and hid the failure from CI.

Require trash 5.3.0 and enable freedesktop only for its supported Unix
targets, retaining the native macOS and Windows backends and the optional
trash-move feature. Refresh the lockfile so CI builds the affected version.

Assisted-by: GPT 6.1 Sol
Co-authored-by: GPT 6.1 Sol <codex@openai.com>
@Byron
Byron marked this pull request as ready for review November 9, 2026 19:27
@Byron
Byron merged commit e59cb79 into main Nov 9, 2026
4 checks passed
@Byron
Byron deleted the trash-build branch November 9, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 3.0.0 fails to compile with trash 5.3.0: Feature freedesktop not enabled

1 participant